Skip to content

Conversation

@Grufoony
Copy link
Collaborator

From now on, streets have ownership of agents.
Hopefully this will improve runtime performances.

@Grufoony Grufoony requested a review from sbaldu February 25, 2025 11:43
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 93.37748% with 40 lines in your changes missing coverage. Please review.

Project coverage is 91.50%. Comparing base (6b1cbc8) to head (a029816).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dsm/headers/RoadDynamics.hpp 90.27% 18 Missing ⚠️
src/dsm/sources/FirstOrderDynamics.cpp 57.14% 6 Missing ⚠️
src/dsm/sources/RoadNetwork.cpp 76.47% 4 Missing ⚠️
src/dsm/sources/Station.cpp 50.00% 4 Missing ⚠️
src/dsm/sources/Street.cpp 89.65% 3 Missing ⚠️
src/dsm/sources/Intersection.cpp 71.42% 2 Missing ⚠️
src/dsm/sources/RoadJunction.cpp 88.88% 2 Missing ⚠️
src/dsm/headers/Roundabout.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   90.95%   91.50%   +0.55%     
==========================================
  Files          36       38       +2     
  Lines        5153     5088      -65     
  Branches      463      438      -25     
==========================================
- Hits         4687     4656      -31     
+ Misses        466      432      -34     
Flag Coverage Δ
unittests 91.50% <93.37%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@Grufoony Grufoony merged commit 9186356 into main Mar 10, 2025
31 checks passed
@Grufoony Grufoony deleted the ReworkAgentHandling branch March 10, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Street queues Replace Ids logic with pointers

2 participants